D25907: [platforms/drm] Introduce Gl post-process output rotations

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in egl_gbm_backend.cpp:260
> seems unused?
> Personally I'd say it's the better name.

I added this at some point because the GLShader and/or GLVertexBuffer classes were somewhat expecting a uniform variable of this name to be in the shader. But I don't remember if I also checked back one last time in the end without it.

> davidedmundson wrote in egl_gbm_backend.cpp:274
> Can we make such GLSL assumptions?
> 
> I expect this would error on the phone.
> 
> ShaderManager::instance()->pushShader(ShaderTrait::MapTexture)
> 
> would be safer.

Yea, good question about the versioning. While working on it I just chose the one that worked on my system, but you're right these won't work on every system. Since the shader is pretty simple would it be enough to rewrite it as a version 110 shader to get it to work everywhere (although I then don't understand why most effects have a 110 an 140 version and not just the 110)?

I didn't use the MapTexture trait because when doing that certain assumptions are being made about the shader that only fit shaders created for Scene rendering.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25907

To: romangg, #kwin
Cc: davidedmundson, PureTryOut, z3ntu, zzag, univerz, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191216/cdb7ca05/attachment.html>