D25904: [libkwineffects] Set original backend framebuffer for render targets

[Fredrik Höglund]

fredrik added inline comments.

INLINE COMMENTS

> kwinglutils.cpp:1091
>      if (s_renderTargets.isEmpty()) {
>          glGetIntegerv(GL_VIEWPORT, s_virtualScreenViewport);
>      }

I'd also like to see a matching setDefaultViewport(), because calls to glGet*() forces serialization of the internal driver threads.

> kwinglutils.h:552
> +     */
> +    static void setKWinFramebuffer(GLuint fb) {
> +        s_kwinFramebuffer = fb;

Could we name this setDefaultFramebuffer()?

I think the documentation is also a bit misleading, because it is not necessarily the framebuffer object currently being rendered to. It's the framebuffer at the very bottom of the stack.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25904

To: romangg, #kwin
Cc: fredrik, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/d7922b99/attachment.html>