D25907: [platforms/drm] Introduce Gl post-process output rotations

Roman Gilg noreply at phabricator.kde.org
Wed Dec 11 22:01:22 GMT 2019


romangg added a comment.


  In D25907#575911 <https://phabricator.kde.org/D25907#575911>, @zzag wrote:
  
  > A client may provide buffers with already rotated contents. Will such clients be a big problem with this patch series?
  
  
  I don't think so. Rotated content is meant for direct scanout. In this case we would not go through rendering path and likely also not through post-processing. But since we don't have direct scanout at the moment this possibility is not (yet) relevant. And on the other side if we go through rendering path we re-rotate the content already in the Scene render to place the content into it.

INLINE COMMENTS

> egl_gbm_backend.h:80
> +            std::shared_ptr<GLShader> shader;
> +
> +        } render;

Remove empty line

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25907

To: romangg, #kwin
Cc: zzag, univerz, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/f36b1049/attachment.html>


More information about the kwin mailing list