D25663: Initial support for tablets on Wayland

[Roman Gilg]

romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.


  In D25663#574166 <https://phabricator.kde.org/D25663#574166>, @apol wrote:
  
  > > I would say as with touch and pointer input there should be a focus update when the pen touches down (update() function)
  >
  > It doesn't make much sense that we need to update() focus from input collection, especially in this patch that is about exposing the data. I'm not sure though.
  
  
  Ok, we can look at that later.
  
  See remaining style comments.

INLINE COMMENTS

> input.cpp:1975
> +
> +        connect(conn, &LibInput::Connection::tabletToolEvent, m_tablet, &TabletInputRedirection::tabletToolEvent);
> +        connect(conn, &LibInput::Connection::tabletToolButtonEvent, m_tablet, &TabletInputRedirection::tabletToolButtonEvent);

These lines are still longer than 100 chars.

> events.h:227
> +
> +    bool isTipDown() const { return libinput_event_tablet_tool_get_tip_state(m_tabletToolEvent) == LIBINPUT_TABLET_TOOL_TIP_DOWN; }
> +    bool isNearby() const { return libinput_event_tablet_tool_get_proximity_state(m_tabletToolEvent) == LIBINPUT_TABLET_TOOL_PROXIMITY_STATE_IN; }

These lines are still longer than 100 chars.

> tablet_input.cpp:112
> +
> +    input()->processSpies(std::bind(&InputEventSpy::tabletToolButtonEvent, std::placeholders::_1, m_toolPressedButtons));
> +    input()->processFilters(std::bind(&InputEventFilter::tabletToolButtonEvent, std::placeholders::_1, m_toolPressedButtons));

These lines are still longer than 100 chars.

> tablet_input.h:55
> +
> +    void tabletToolEvent(KWin::InputRedirection::TabletEventType type, const QPointF &pos, qreal pressure,
> +                         int xTilt, int yTilt, qreal rotation, bool tipDown, bool tipNear,

These lines are still longer than 100 chars.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25663

To: apol, #plasma, #kwin, romangg
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191210/78df6266/attachment.html>