<table><tr><td style="">romangg requested changes to this revision.<br />romangg added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25663">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25663#574166" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25663#574166</a>, <a href="https://phabricator.kde.org/p/apol/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@apol</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I would say as with touch and pointer input there should be a focus update when the pen touches down (update() function)</p></blockquote>
<p>It doesn't make much sense that we need to update() focus from input collection, especially in this patch that is about exposing the data. I'm not sure though.</p></div>
</blockquote>
<p>Ok, we can look at that later.</p>
<p>See remaining style comments.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145825">View Inline</a><span style="color: #4b4d51; font-weight: bold;">input.cpp:1975</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">conn</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LibInput</span><span style="color: #aa2211">::</span><span class="n">Connection</span><span style="color: #aa2211">::</span><span class="n">tabletToolEvent</span><span class="p">,</span> <span class="n">m_tablet</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">TabletInputRedirection</span><span style="color: #aa2211">::</span><span class="n">tabletToolEvent</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">conn</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">LibInput</span><span style="color: #aa2211">::</span><span class="n">Connection</span><span style="color: #aa2211">::</span><span class="n">tabletToolButtonEvent</span><span class="p">,</span> <span class="n">m_tablet</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">TabletInputRedirection</span><span style="color: #aa2211">::</span><span class="n">tabletToolButtonEvent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These lines are still longer than 100 chars.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145826">View Inline</a><span style="color: #4b4d51; font-weight: bold;">events.h:227</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span style="color: #004012">isTipDown</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">libinput_event_tablet_tool_get_tip_state</span><span class="p">(</span><span class="n">m_tabletToolEvent</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="n">LIBINPUT_TABLET_TOOL_TIP_DOWN</span><span class="p">;</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">bool</span> <span style="color: #004012">isNearby</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span class="n">libinput_event_tablet_tool_get_proximity_state</span><span class="p">(</span><span class="n">m_tabletToolEvent</span><span class="p">)</span> <span style="color: #aa2211">==</span> <span class="n">LIBINPUT_TABLET_TOOL_PROXIMITY_STATE_IN</span><span class="p">;</span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These lines are still longer than 100 chars.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145827">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_input.cpp:112</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">input</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">processSpies</span><span class="p">(</span><span class="n">std</span><span style="color: #aa2211">::</span><span class="n">bind</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">InputEventSpy</span><span style="color: #aa2211">::</span><span class="n">tabletToolButtonEvent</span><span class="p">,</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">placeholders</span><span style="color: #aa2211">::</span><span class="n">_1</span><span class="p">,</span> <span class="n">m_toolPressedButtons</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">input</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">processFilters</span><span class="p">(</span><span class="n">std</span><span style="color: #aa2211">::</span><span class="n">bind</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">InputEventFilter</span><span style="color: #aa2211">::</span><span class="n">tabletToolButtonEvent</span><span class="p">,</span> <span class="n">std</span><span style="color: #aa2211">::</span><span class="n">placeholders</span><span style="color: #aa2211">::</span><span class="n">_1</span><span class="p">,</span> <span class="n">m_toolPressedButtons</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These lines are still longer than 100 chars.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145828">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_input.h:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">tabletToolEvent</span><span class="p">(</span><span class="n">KWin</span><span style="color: #aa2211">::</span><span class="n">InputRedirection</span><span style="color: #aa2211">::</span><span class="n">TabletEventType</span> <span class="n">type</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QPointF</span> <span style="color: #aa2211">&</span><span class="n">pos</span><span class="p">,</span> <span class="n">qreal</span> <span class="n">pressure</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">xTilt</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">yTilt</span><span class="p">,</span> <span class="n">qreal</span> <span class="n">rotation</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">tipDown</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">tipNear</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These lines are still longer than 100 chars.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25663">https://phabricator.kde.org/D25663</a></div></div><br /><div><strong>To: </strong>apol, Plasma, KWin, romangg<br /><strong>Cc: </strong>romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>