D25663: Initial support for tablets on Wayland
Roman Gilg
noreply at phabricator.kde.org
Thu Dec 5 19:30:51 GMT 2019
romangg requested changes to this revision.
romangg added a comment.
This revision now requires changes to proceed.
- Still needs several styling corrections.
- I would say as with touch and pointer input there should be a focus update when the pen touches down (`update()` function)
INLINE COMMENTS
> tablet_input.cpp:92
> + QTabletEvent ev(t, pos, pos, QTabletEvent::Stylus, QTabletEvent::Pen, pressure, xTilt, yTilt,
> + 0 /*tangentialPressure*/, rotation, 0 /*z*/, Qt::NoModifier, serialId, button, button);
> +
No inline comments, make it mutliple lines, put comment as `// comments` behind arguments.
> tablet_input.h:76
> +private:
> + void cleanupDecoration(Decoration::DecoratedClientImpl */*old*/, Decoration::DecoratedClientImpl */*now*/) override
> + {
Implement in cpp file. There use Q_UNUSED macro.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D25663
To: apol, #plasma, #kwin, romangg
Cc: romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191205/72cb8026/attachment.html>
More information about the kwin
mailing list