<table><tr><td style="">romangg requested changes to this revision.<br />romangg added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25663">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Still needs several styling corrections.</li>
<li class="remarkup-list-item">I would say as with touch and pointer input there should be a focus update when the pen touches down (<tt style="background: #ebebeb; font-size: 13px;">update()</tt> function)</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145247">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_input.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QTabletEvent</span> <span style="color: #004012">ev</span><span class="p">(</span><span class="n">t</span><span class="p">,</span> <span class="n">pos</span><span class="p">,</span> <span class="n">pos</span><span class="p">,</span> <span class="n">QTabletEvent</span><span style="color: #aa2211">::</span><span class="n">Stylus</span><span class="p">,</span> <span class="n">QTabletEvent</span><span style="color: #aa2211">::</span><span class="n">Pen</span><span class="p">,</span> <span class="n">pressure</span><span class="p">,</span> <span class="n">xTilt</span><span class="p">,</span> <span class="n">yTilt</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #601200">0</span> <span style="color: #74777d">/*tangentialPressure*/</span><span class="p">,</span> <span class="n">rotation</span><span class="p">,</span> <span style="color: #601200">0</span> <span style="color: #74777d">/*z*/</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">NoModifier</span><span class="p">,</span> <span class="n">serialId</span><span class="p">,</span> <span class="n">button</span><span class="p">,</span> <span class="n">button</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No inline comments, make it mutliple lines, put comment as <tt style="background: #ebebeb; font-size: 13px;">// comments</tt> behind arguments.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D25663#inline-145246">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tablet_input.h:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #a0a000">private</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span class="n">cleanupDecoration</span><span class="p">(</span><span class="n">Decoration</span><span style="color: #aa2211">::</span><span class="n">DecoratedClientImpl</span> <span class="err">*/</span><span style="color: #aa2211">*</span><span class="n">old</span><span class="err">*/</span><span class="p">,</span> <span class="n">Decoration</span><span style="color: #aa2211">::</span><span class="n">DecoratedClientImpl</span> <span class="err">*/</span><span style="color: #aa2211">*</span><span class="n">now</span><span class="err">*/</span><span class="p">)</span> <span class="n">override</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Implement in cpp file. There use Q_UNUSED macro.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25663">https://phabricator.kde.org/D25663</a></div></div><br /><div><strong>To: </strong>apol, Plasma, KWin, romangg<br /><strong>Cc: </strong>romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>