D23511: Remove vsync detection and configurability

Roman Gilg noreply at phabricator.kde.org
Tue Aug 27 21:28:29 BST 2019


romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  Selecting not to vsync does not make sense for an X11 compositor. In the end
  we want clients to be able to present async if they want to but the compositor
  is supposed to send swaps with vsync to the XServer in order to not generate
  tearing artifacts.
  
  There was also a detection logic which did some questionable things in case
  vsync was not available. I don't think this is necessary at all since we can
  just always run a timer to present with or without vsync.

TEST PLAN
  kwin_x11 tested on i915.

REPOSITORY
  R108 KWin

BRANCH
  rmVsyncConfig

REVISION DETAIL
  https://phabricator.kde.org/D23511

AFFECTED FILES
  composite.cpp
  platformsupport/scenes/opengl/backend.cpp
  platformsupport/scenes/opengl/backend.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_stream_backend.cpp
  plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp
  plugins/platforms/x11/common/eglonxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h
  plugins/scenes/opengl/scene_opengl.cpp
  plugins/scenes/opengl/scene_opengl.h
  scene.cpp
  scene.h

To: romangg, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190827/f9fe2ca2/attachment.html>


More information about the kwin mailing list