D23473: [platforms/wayland] Create output devices

Roman Gilg noreply at phabricator.kde.org
Tue Aug 27 08:45:39 BST 2019


romangg added inline comments.

INLINE COMMENTS

> zzag wrote in wayland_output.cpp:64
> Do you want to change these strings in the future?

Sure. We could go with something like `org.kde.kwin` as manufacturer and `wayland-nested#` where # is the output number.

> zzag wrote in wayland_output.h:56
> Make `init` a private method and WaylandBackend a friend class.

Why do you prefer this? I try to omit friend classes in general since it dilutes the concept of access restrictions.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23473

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190827/ba817765/attachment.html>


More information about the kwin mailing list