D23473: [platforms/wayland] Create output devices

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> wayland_output.cpp:63
> +    mode.flags = KWayland::Server::OutputDeviceInterface::ModeFlag::Current;
> +    mode.refreshRate = 60000;  // TODO
> +    AbstractWaylandOutput::initWaylandOutputDevice("model_TODO", "manufacturer_TODO",

There are couple places in KWin core with just `// TODO`. I still wonder what those comments mean. Please add some meaningful text to the todo comment.

> wayland_output.cpp:64
> +    mode.refreshRate = 60000;  // TODO
> +    AbstractWaylandOutput::initWaylandOutputDevice("model_TODO", "manufacturer_TODO",
> +                                                   "UUID_TODO", { mode });

Do you want to change these strings in the future?

> wayland_output.h:53
>  public:
> -    explicit WaylandOutput(KWayland::Client::Surface *surface, QObject *parent = nullptr);
> +    explicit WaylandOutput(KWayland::Client::Surface *surface, WaylandBackend *backend);
>      ~WaylandOutput() override;

Remove `explicit`.

> wayland_output.h:56
>  
> +    void init(const QPoint &logicalPosition, const QSize &pixelSize);
> +

Make `init` a private method and WaylandBackend a friend class.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23473

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190827/57038c56/attachment-0001.html>