D23120: Use compiler __SSE2__ definitions and C++11 alignas

Frederik Gladhorn noreply at phabricator.kde.org
Tue Aug 13 20:35:55 BST 2019


gladhorn added a comment.


  In D23120#511135 <https://phabricator.kde.org/D23120#511135>, @zzag wrote:
  
  > > There seem to be frequent crashes in the quad version of this code, but
  > >  this change should not make any difference from what I can tell.
  >
  > I doubt that kwin crashes because of alignment issues. I suggest looking into whether GLVertexBuffer::streamingBuffer() is still valid.
  
  
  I agree, I first thought the alignment would be the problem, but after reading the code, I don't see how it would be an issue, thanks for the tip.

INLINE COMMENTS

> zzag wrote in kwineffects.cpp:1137
> Stick only with either ifdef or if defined. Mixing both can be confusing for some people.

Agree, that was sloppy.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23120

To: gladhorn, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190813/cc24ccb5/attachment.html>


More information about the kwin mailing list