D23120: Use compiler __SSE2__ definitions and C++11 alignas

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Aug 13 09:32:00 BST 2019


zzag added a comment.


  > There seem to be frequent crashes in the quad version of this code, but
  >  this change should not make any difference from what I can tell.
  
  I doubt that kwin crashes because of alignment issues. I suggest looking into whether GLVertexBuffer::streamingBuffer() is still valid.

INLINE COMMENTS

> kwineffects.cpp:1137
>      case GL_QUADS:
> -#ifdef HAVE_SSE2
> +#if defined(__SSE2__)
>          if (!(intptr_t(vertex) & 0xf)) {

Stick only with either ifdef or if defined. Mixing both can be confusing for some people.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23120

To: gladhorn, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190813/1dfd5b00/attachment.html>


More information about the kwin mailing list