D23067: Clean up usage of m_client

Frederik Gladhorn noreply at phabricator.kde.org
Tue Aug 13 07:21:56 BST 2019


gladhorn added inline comments.

INLINE COMMENTS

> zzag wrote in useractions.cpp:135-139
> This piece of code contradicts to Q_ASSERT above. Delete the if statement.

Remember that asserts are only in debug builds, most users will run release builds. I do agree though that this is somewhat redundant. If the assert is valid, which I think it is, then it should never trigger and we can remove the if, if the assert turns out to be wrong, then it can be removed. In either case, release builds should work and not crash, while debug builds will expose potential issues.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23067

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190813/69dadedd/attachment.html>


More information about the kwin mailing list