D23067: Clean up usage of m_client

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Aug 12 22:54:40 BST 2019


zzag added inline comments.

INLINE COMMENTS

> useractions.cpp:135-139
> +    // Presumably client will never be nullptr,
> +    // but play it safe and make sure not to crash.
> +    if (cl.isNull()) {
>          return;
> +    }

This piece of code contradicts to Q_ASSERT above. Delete the if statement.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23067

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190812/3f2abc51/attachment.html>


More information about the kwin mailing list