D22914: [kcmkwin/kwineffects] Improve the look of the Desktop Effects KCM list items

Nathaniel Graham noreply at phabricator.kde.org
Sun Aug 4 14:45:41 BST 2019


ngraham added a comment.


  +1 for the extra vertical spacing. +1 for using a Kirigami Heading, which is semantically appropriate here.
  
  Let's make the opacity just 0.7, not alternating between 0.6 and 0.8. Even though I don't like it, I won't turn this patch into a vehicle for complaining about our allergy to bold header text. :)
  
  However I will leave this screenshot here:
  
  F7159190: Screenshot_20190804_074422.png <https://phabricator.kde.org/F7159190>
  
  Doesn't it noticeably improve the visual hierarchy to make the category headers bold? Making the text slightly larger (size 3 to size 2) doesn't cut it IMO. In fact I think there's really not enough visual difference between size 3 and size 2 in general, while the gap between 2 and 1 is huge.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22914

To: GB_2, #kwin, #plasma, #vdg
Cc: ngraham, #vdg, #plasma, kwin, #kwin, LeGast00n, fmonteiro, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190804/b14c9465/attachment.html>


More information about the kwin mailing list