Review Request 104329: some fixme issues tackled

[Albert Astals Cid]

> On Jan. 11, 2014, 4:40 p.m., Albert Astals Cid wrote:
> > This patch does not apply anymore, can you please rebase it?
> > 
> > Also I'd suggest you discard this review since you tainted it by giving yourself a ship it and you create a new one.

No asnwer in 3 years, discarding.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104329/#review47209
-----------------------------------------------------------


On March 18, 2012, 7:18 a.m., Vageesh DC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/104329/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 7:18 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> the following were incorporated:
> 1.making  SkyPoint::updateCoords() faster
> 2.div by zero handling in SkyPoint::SkyPoint()
> 3. drawing clipped line in void SkyGLPainter::drawSkyLine()
> 
> 
> Diffs
> -----
> 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsinit.cpp bbc70fe 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsui.rc 9ee4b0e 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/linelistlabel.cpp 0be66e4 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/skymapcomposite.cpp 8b83c08 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyglpainter.cpp 2a74af9 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/skypoint.cpp 19feb91 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/starobject.cpp a35ccd6 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyqpainter.cpp 43f06e8 
>   home/ganesha/Desktop/march/kstars.orig/kstars/kstars/tools/observinglist.cpp 3d4ac99 
> 
> Diff: https://git.reviewboard.kde.org/r/104329/diff/
> 
> 
> Testing
> -------
> 
> tested all.no build issues
> 
> 
> Thanks,
> 
> Vageesh DC
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20170121/c3ec2276/attachment.html>