<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/104329/">https://git.reviewboard.kde.org/r/104329/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 11th, 2014, 4:40 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does not apply anymore, can you please rebase it?
Also I'd suggest you discard this review since you tainted it by giving yourself a ship it and you create a new one.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No asnwer in 3 years, discarding.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On March 18th, 2012, 7:18 a.m. UTC, Vageesh DC wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KStars, Akarsh Simha and Rafal Kulaga.</div>
<div>By Vageesh DC.</div>
<p style="color: grey;"><i>Updated March 18, 2012, 7:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the following were incorporated:
1.making SkyPoint::updateCoords() faster
2.div by zero handling in SkyPoint::SkyPoint()
3. drawing clipped line in void SkyGLPainter::drawSkyLine()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested all.no build issues</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsinit.cpp <span style="color: grey">(bbc70fe)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/kstarsui.rc <span style="color: grey">(9ee4b0e)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/linelistlabel.cpp <span style="color: grey">(0be66e4)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skycomponents/skymapcomposite.cpp <span style="color: grey">(8b83c08)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyglpainter.cpp <span style="color: grey">(2a74af9)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/skypoint.cpp <span style="color: grey">(19feb91)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyobjects/starobject.cpp <span style="color: grey">(a35ccd6)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/skyqpainter.cpp <span style="color: grey">(43f06e8)</span></li>
<li>home/ganesha/Desktop/march/kstars.orig/kstars/kstars/tools/observinglist.cpp <span style="color: grey">(3d4ac99)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/104329/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>