[Kstars-devel] Review Request 126744: "Improve Altitude vs. Time tool" - implemented with QCustomPlot library, new improvements

[Raphael Cojocaru]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126744/
-----------------------------------------------------------

(Updated Ian. 14, 2016, 5:30 p.m.)


Review request for KStars and Jasem Mutlaq.


Repository: kstars


Description
-------

"Improve Altitude vs. Time tool" - Zoom/Pan limitations and other improvements


Diffs
-----

  kstars/auxiliary/qcustomplot.h 7352383 
  kstars/tools/altvstime.h 5b160b9 
  kstars/tools/altvstime.cpp 6863c47 
  kstars/tools/altvstime.ui 2cdda14 

Diff: https://git.reviewboard.kde.org/r/126744/diff/


Testing (updated)
-------

Tested with various SkyObjects. 
This patch brings several improvements to my previous work: now the Zoom/Pan options are limited to the today's curve. 
Here is a brief overview on my work: ( I will mark with the tag "NEW", the improvements I made since the last patch ) 
- Set up the graph window
- NEW: Set up the axis labels, Date time format and tick step ( the time's units need to be discrete like: 01:00, 02:00 )
- NEW: Set up the Top X Axis ( "Local Sidereal Time" )
- Set up the interaction set: Zoom/Pan are now ready for use
- NEW: Set up the margins, for a nice view ( e.g. in the right side, the graph window was not closed before)
- NEW: Set up the Zoom/Pan activated for the Top X Axis
- NEW: Because I need a kind of limitation regarding the Zoom/Pan for the current curve, I have used:
1. 2 variables for minimum and maximum altitude from the current graph ( for every curve that we insert into our graph, the minAlt and maxAlt variables are updated )
2. these variables are extremely useful to limit the Y axis to our graph most significant curve regarding the minimum and maximum value
3. 2 new slots: onXRangeChanged and onYRangeChanged, to update and limit the axes
- With all of these, I have connected the slots to the axes, with one remark: the xAxis and xAxis2 are connected through the same slot, to behave as same
- Rewrite the code for making existing curves with thin and red pencil
- NEW: A short algorithm for setting up the tick step for xAxis and xAxis2 depending on the Zoom level ( like: a half an hour after some zoom level: 1:30, 2:00; a quarter hour after another zoom level and so on. This is necessary because there wouldn't be anything to see if the initial tick step would be maintained while continuously zooming )
- Rewrite the method for removing all curves from the plot ( cleaning the graph)

For now I have a small bug to fix:
When I'm drawing a curve, the delay between top and bottom X axes is present, but after several Zoom In scrolls, the ranges become identical for both X axes. So I'm trying to solve it.
There is a before & after picture that shows the improvements I made since my last patch:
http://s9.postimg.org/5db2cvf9r/before_after.jpg


Thanks,

Raphael Cojocaru

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160114/47796636/attachment.html>