<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126744/">https://git.reviewboard.kde.org/r/126744/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KStars and Jasem Mutlaq.</div>
<div>By Raphael Cojocaru.</div>
<p style="color: grey;"><i>Updated Ian. 14, 2016, 5:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Improve Altitude vs. Time tool" - Zoom/Pan limitations and other improvements</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with various SkyObjects.
This patch brings several improvements to my previous work: now the Zoom/Pan options are limited to the today's curve.
Here is a brief overview on my work: ( I will mark with the tag "NEW", the improvements I made since the last patch )
- Set up the graph window
- NEW: Set up the axis labels, Date time format and tick step ( the time's units need to be discrete like: 01:00, 02:00 )
- NEW: Set up the Top X Axis ( "Local Sidereal Time" )
- Set up the interaction set: Zoom/Pan are now ready for use
- NEW: Set up the margins, for a nice view ( e.g. in the right side, the graph window was not closed before)
- NEW: Set up the Zoom/Pan activated for the Top X Axis
- NEW: Because I need a kind of limitation regarding the Zoom/Pan for the current curve, I have used:
1. 2 variables for minimum and maximum altitude from the current graph ( for every curve that we insert into our graph, the minAlt and maxAlt variables are updated )
2. these variables are extremely useful to limit the Y axis to our graph most significant curve regarding the minimum and maximum value
3. 2 new slots: onXRangeChanged and onYRangeChanged, to update and limit the axes
- With all of these, I have connected the slots to the axes, with one remark: the xAxis and xAxis2 are connected through the same slot, to behave as same
- Rewrite the code for making existing curves with thin and red pencil
- NEW: A short algorithm for setting up the tick step for xAxis and xAxis2 depending on the Zoom level ( like: a half an hour after some zoom level: 1:30, 2:00; a quarter hour after another zoom level and so on. This is necessary because there wouldn't be anything to see if the initial tick step would be maintained while continuously zooming )
- Rewrite the method for removing all curves from the plot ( cleaning the graph)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For now I have a small bug to fix:
When I'm drawing a curve, the delay between top and bottom X axes is present, but after several Zoom In scrolls, the ranges become identical for both X axes. So I'm trying to solve it.
There is a before & after picture that shows the improvements I made since my last patch:
http://s9.postimg.org/5db2cvf9r/before_after.jpg</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/auxiliary/qcustomplot.h <span style="color: grey">(7352383)</span></li>
<li>kstars/tools/altvstime.h <span style="color: grey">(5b160b9)</span></li>
<li>kstars/tools/altvstime.cpp <span style="color: grey">(6863c47)</span></li>
<li>kstars/tools/altvstime.ui <span style="color: grey">(2cdda14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126744/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>