[Kstars-devel] Review Request 127116: Port What's Interesting tool to QML 2

[Artem Fedoskin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127116/
-----------------------------------------------------------

(Updated Feb. 26, 2016, 6:29 p.m.)


Review request for KStars.


Changes
-------

1. Refactored the code. Deleted excessive anchors and text align attributes. Created separate components for repeated parts of code.
2. Fixed bug with Flipable area when the user wasn't able to click "Slew map to object" and part of "More object details" buttons
2. Changed Rectangles to Item as it doesn't require resources to draw itself. (http://imaginativethinking.ca/qt-quick-performance-tips-rectangles/)


Repository: kstars


Description
-------

1. Changed roleNames() in SkyObjItem and SkyObjListModel to suit actual version of QAbstractListModel
2. Used KLocalizedContext instead of KDeclarative in tools/whatsinteresting/wiview.cpp on line 43. KLocalizedContext provides more convenient way to use i18n() and xi18n() in QML files. On my system (Kubuntu 15.10) I had to install libkf5i18n-dev from backports repository to get KLocalizedContext, but it is already listed in KDE API Documentation so I don't know why it is available only in backports repository. Use of KLocalizedContext is also good for future QML projects.
3. Changed custom scrolling ScrollBar to ScrollView from QtQuick.Controls, which provides platform’s native look and feel.
4. Changed deprecated QStandardPaths::DataLocation to QStandardPaths::AppDataLocation in file wiview.cpp.


Diffs (updated)
-----

  CMakeLists.txt 2148e04 
  kstars/CMakeLists.txt ef2227a 
  kstars/kstars.h 39a7ad0 
  kstars/kstars.cpp 73e590f 
  kstars/kstarsactions.cpp aeef2fc 
  kstars/kstarsinit.cpp e6af58a 
  kstars/tools/whatsinteresting/qml/CMakeLists.txt a5ae3f8 
  kstars/tools/whatsinteresting/qml/CategoryTitle.qml PRE-CREATION 
  kstars/tools/whatsinteresting/qml/DetailsItem.qml PRE-CREATION 
  kstars/tools/whatsinteresting/qml/wiview.qml f576ae0 
  kstars/tools/whatsinteresting/skyobjitem.h ba163c4 
  kstars/tools/whatsinteresting/skyobjitem.cpp de03829 
  kstars/tools/whatsinteresting/skyobjlistmodel.h 17cfe4c 
  kstars/tools/whatsinteresting/skyobjlistmodel.cpp a3c6519 
  kstars/tools/whatsinteresting/wiview.cpp b05915e 

Diff: https://git.reviewboard.kde.org/r/127116/diff/


Testing
-------

Compiles and What's Interesting tool runs fine.


Thanks,

Artem Fedoskin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20160226/d8a08c07/attachment.html>