<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127116/">https://git.reviewboard.kde.org/r/127116/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KStars.</div>
<div>By Artem Fedoskin.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2016, 6:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Refactored the code. Deleted excessive anchors and text align attributes. Created separate components for repeated parts of code.
2. Fixed bug with Flipable area when the user wasn't able to click "Slew map to object" and part of "More object details" buttons
2. Changed Rectangles to Item as it doesn't require resources to draw itself. (http://imaginativethinking.ca/qt-quick-performance-tips-rectangles/)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Changed roleNames() in SkyObjItem and SkyObjListModel to suit actual version of QAbstractListModel</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Used KLocalizedContext instead of KDeclarative in tools/whatsinteresting/wiview.cpp on line 43. KLocalizedContext provides more convenient way to use i18n() and xi18n() in QML files. On my system (Kubuntu 15.10) I had to install libkf5i18n-dev from backports repository to get KLocalizedContext, but it is already listed in KDE API Documentation so I don't know why it is available only in backports repository. Use of KLocalizedContext is also good for future QML projects.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Changed custom scrolling ScrollBar to ScrollView from QtQuick.Controls, which provides platform’s native look and feel.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Changed deprecated QStandardPaths::DataLocation to QStandardPaths::AppDataLocation in file wiview.cpp.</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and What's Interesting tool runs fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2148e04)</span></li>
<li>kstars/CMakeLists.txt <span style="color: grey">(ef2227a)</span></li>
<li>kstars/kstars.h <span style="color: grey">(39a7ad0)</span></li>
<li>kstars/kstars.cpp <span style="color: grey">(73e590f)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(aeef2fc)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(e6af58a)</span></li>
<li>kstars/tools/whatsinteresting/qml/CMakeLists.txt <span style="color: grey">(a5ae3f8)</span></li>
<li>kstars/tools/whatsinteresting/qml/CategoryTitle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/DetailsItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/wiview.qml <span style="color: grey">(f576ae0)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.h <span style="color: grey">(ba163c4)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.cpp <span style="color: grey">(de03829)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.h <span style="color: grey">(17cfe4c)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.cpp <span style="color: grey">(a3c6519)</span></li>
<li>kstars/tools/whatsinteresting/wiview.cpp <span style="color: grey">(b05915e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127116/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>