[Kstars-devel] Review Request 126532: KStars: A new HiDPI-ready world map image and logic for mapcanvas

[Jasem Mutlaq]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126532/#review90213
-----------------------------------------------------------


The slow clicking is a regression as I confirmed it doesn't exist in the current version. I will have to investigate more to find out what's causing this. Also, the image size is static (in the current code) and does not respond to the dialog resize event, will try to fix that as well. Of course, if you can investigate these issues as well it would be great!

- Jasem Mutlaq


On Dec. 27, 2015, 12:33 a.m., Dmytro Shynkevych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126532/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 12:33 a.m.)
> 
> 
> Review request for KStars and Andreas Cord-Landwehr.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Now the world map is not pixelated on HiDPI settings anymore (with QT_DEVICE_PIXEL_RATIO up to 7.5, that is).
> The image used is public domain, taken from here: http://www.westnet.com/~crywalt/unfold.html. It needs to be put in kstars/data (see the diff).
> 
> 
> Diffs
> -----
> 
>   kstars/data/CMakeLists.txt 7c5724c 
>   kstars/data/geomap.jpg PRE-CREATION 
>   kstars/data/geomap.png 7dfd6f9 
>   kstars/widgets/mapcanvas.cpp 79ad547 
> 
> Diff: https://git.reviewboard.kde.org/r/126532/diff/
> 
> 
> Testing
> -------
> 
> Tested on my machine with QT_DEVICE_PIXEL_RATIO from 1 to 4, no regressions found.
> However, clicking somewhat far from the original position (e.g. North America to Australia) is painfully slow. It is not a regression, as this exact behavior is present in the upstream code.
> 
> 
> File Attachments
> ----------------
> 
> geomap.jpg
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/f276d66b-6b51-4ffb-b8f0-81de51cd0286__geomap.jpg
> 
> 
> Thanks,
> 
> Dmytro Shynkevych
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20151228/9a27643a/attachment.html>