<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126532/">https://git.reviewboard.kde.org/r/126532/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The slow clicking is a regression as I confirmed it doesn't exist in the current version. I will have to investigate more to find out what's causing this. Also, the image size is static (in the current code) and does not respond to the dialog resize event, will try to fix that as well. Of course, if you can investigate these issues as well it would be great!</p></pre>
<br />
<p>- Jasem Mutlaq</p>
<br />
<p>On December 27th, 2015, 12:33 a.m. UTC, Dmytro Shynkevych wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KStars and Andreas Cord-Landwehr.</div>
<div>By Dmytro Shynkevych.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2015, 12:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now the world map is not pixelated on HiDPI settings anymore (with QT_DEVICE_PIXEL_RATIO up to 7.5, that is).
The image used is public domain, taken from here: http://www.westnet.com/~crywalt/unfold.html. It needs to be put in kstars/data (see the diff).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on my machine with QT_DEVICE_PIXEL_RATIO from 1 to 4, no regressions found.
However, clicking somewhat far from the original position (e.g. North America to Australia) is painfully slow. It is not a regression, as this exact behavior is present in the upstream code.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/data/CMakeLists.txt <span style="color: grey">(7c5724c)</span></li>
<li>kstars/data/geomap.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/data/geomap.png <span style="color: grey">(7dfd6f9)</span></li>
<li>kstars/widgets/mapcanvas.cpp <span style="color: grey">(79ad547)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126532/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/12/27/f276d66b-6b51-4ffb-b8f0-81de51cd0286__geomap.jpg">geomap.jpg</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>