[Kstars-devel] Review Request 112667: Add solar/lunar eclipse button to conjunction tool

Albert Astals Cid aacid at kde.org
Sun Jan 12 21:34:12 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review47269
-----------------------------------------------------------


Doesn't apply cleanly anymore, can you please rebase your patch into master?

- Albert Astals Cid


On Oct. 18, 2013, 1:50 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
> 
> Review request for KDE Edu, KStars and Akarsh Simha.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Add solar/lunar eclipse button to conjunctions tool for better usability 
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/skypoint.cpp f634075 
>   kstars/tools/conjunctions.h b51209e 
>   kstars/tools/conjunctions.cpp 39cef00 
>   kstars/tools/conjunctions.ui 80374b1 
>   kstars/tools/skycalendar.cpp 3ca61de 
> 
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
> 
> 
> Testing
> -------
> 
> Tested , it predicts correct dates of eclipse but some eclipse may not get displayed
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140112/26d42af7/attachment.html>


More information about the Kstars-devel mailing list