[Kstars-devel] Review Request 111032: Fix empty names in the find dialog.

Albert Astals Cid aacid at kde.org
Sat Jan 11 16:48:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111032/#review47212
-----------------------------------------------------------


This does not apply cleanly to master anymore, can you please rebase it?

- Albert Astals Cid


On Jan. 11, 2014, 4:48 p.m., Aneesh Dogra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111032/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 4:48 p.m.)
> 
> 
> Review request for KDE Edu and KStars.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Edit the setNames method of StarObject to expand greek characters in longname and use the longname() method to get the name of the star in starcomponent.cpp.
> 
> This fixes the empty names in the find dialog, gives out better names for entries and uses less code.
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/starcomponent.cpp a44e37a 
>   kstars/skyobjects/starobject.cpp 8976341 
> 
> Diff: https://git.reviewboard.kde.org/r/111032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aneesh Dogra
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20140111/e4a5344c/attachment.html>


More information about the Kstars-devel mailing list