[Kstars-devel] Review Request 112496: Column for Object 2 is added in conjunctions tool and default width of column is set larger

[Rafal Kulaga]

> On Sept. 14, 2013, 10:25 p.m., Vijay Dhameliya wrote:
> > kstars/tools/conjunctions.h, line 73
> > <http://git.reviewboard.kde.org/r/112496/diff/4/?file=189401#file189401line73>
> >
> >     String objects are passed by const references, I am not able to understand where you are asking to use const reference. Sorry for my dumbness I am improving my c++ concepts just now a days only.

const QString &object1, const QString &object2 will do the job.


- Rafal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112496/#review40034
-----------------------------------------------------------


On Sept. 13, 2013, 10:56 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112496/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:56 p.m.)
> 
> 
> Review request for KStars and Akarsh Simha.
> 
> 
> Description
> -------
> 
> In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping,  when we have calculated many conjunctions from same object 1 to different object 2s.
> 
> 
> Diffs
> -----
> 
>   kstars/tools/conjunctions.cpp 39cef00 
>   kstars/tools/conjunctions.h b51209e 
>   kstars/tools/conjunctions.ui 80374b1 
> 
> Diff: http://git.reviewboard.kde.org/r/112496/diff/
> 
> 
> Testing
> -------
> 
> tested
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130914/3f199dad/attachment.html>