<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112496/">http://git.reviewboard.kde.org/r/112496/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 14th, 2013, 10:25 p.m. UTC, <b>Vijay Dhameliya</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112496/diff/4/?file=189401#file189401line73" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/conjunctions.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">showConjunctions</span><span class="p">(</span><span class="k">const</span> <span class="n">QMap</span><span class="o"><</span><span class="kt">long</span> <span class="kt">double</span><span class="p">,</span> <span class="n">dms</span><span class="o">></span> <span class="o">&</span><span class="n">conjunctionlist</span><span class="p">,</span> <span class="n">QString</span> <span class="n">object</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">73</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">showConjunctions</span><span class="p">(</span><span class="k">const</span> <span class="n">QMap</span><span class="o"><</span><span class="kt">long</span> <span class="kt">double</span><span class="p">,</span> <span class="n">dms</span><span class="o">></span> <span class="o">&</span><span class="n">conjunctionlist</span><span class="p">,</span> <span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">QString</span> <span class="n">object<span class="hl">1</span></span><span class="hl"> </span><span class="p"><span class="hl">,</span></span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n"><span class="hl">QString</span></span><span class="hl"> </span><span class="n"><span class="hl">object2</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">String objects are passed by const references, I am not able to understand where you are asking to use const reference. Sorry for my dumbness I am improving my c++ concepts just now a days only. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">const QString &object1, const QString &object2 will do the job.</pre>
<br />
<p>- Rafal</p>
<br />
<p>On September 13th, 2013, 10:56 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars and Akarsh Simha.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2013, 10:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping, when we have calculated many conjunctions from same object 1 to different object 2s.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>
<li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112496/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png">Conjunction_tool_after.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png">Conjunction_tool_Before.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>