[Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw()

[Vijay Dhameliya]

> On Oct. 28, 2013, 5:58 a.m., Henry de Valence wrote:
> > IMO, there should generally be braces for non-trivial if-statements.
> > 
> > Also, would it be better to instead change KSComet so that it sets the magitude returned by mag() to the correct value, instead of doing a workaround here? That would fix the problem for other users of KSComet, too.

Actually to set magnitude returned by mag() we need to call setMag() from KSComet but since setMag() is protected we can not call it, and other way to set is setting  float variable sortMagnitude = M1 which is also not possible since sortMagnitude is private so we are left with only one option i.e. to use getTotalMagnitudeParameter() whenever required 


- Vijay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113438/#review42506
-----------------------------------------------------------


On Oct. 25, 2013, 10:04 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113438/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 10:04 p.m.)
> 
> 
> Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.
> 
> 
> Bugs: 326647
>     http://bugs.kde.org/show_bug.cgi?id=326647
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Bug:
> ->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
>  
> Fixing:
> -> Drawing KSComet on the basis of Total Magnitude Parameter
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/cometscomponent.cpp 395c856 
>   kstars/dialogs/detaildialog.cpp efda624 
> 
> Diff: http://git.reviewboard.kde.org/r/113438/diff/
> 
> 
> Testing
> -------
> 
> Bug fixed - No more crashing 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131028/c4072600/attachment.html>