[Kstars-devel] Review Request 113438: Fixing bug in CometsComponent::draw()

[Henry de Valence]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113438/#review42506
-----------------------------------------------------------


IMO, there should generally be braces for non-trivial if-statements.

Also, would it be better to instead change KSComet so that it sets the magitude returned by mag() to the correct value, instead of doing a workaround here? That would fix the problem for other users of KSComet, too.

- Henry de Valence


On Oct. 25, 2013, 10:04 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113438/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 10:04 p.m.)
> 
> 
> Review request for KStars, Henry de Valence, Rafal Kulaga, and Rishab Arora.
> 
> 
> Bugs: 326647
>     http://bugs.kde.org/show_bug.cgi?id=326647
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Bug:
> ->Since sortMagnitude for comet is never set, calling mag() in draw class returns NaN which causes crashes while zooming on KSComet object.
>  
> Fixing:
> -> Drawing KSComet on the basis of Total Magnitude Parameter
> 
> 
> Diffs
> -----
> 
>   kstars/skycomponents/cometscomponent.cpp 395c856 
>   kstars/dialogs/detaildialog.cpp efda624 
> 
> Diff: http://git.reviewboard.kde.org/r/113438/diff/
> 
> 
> Testing
> -------
> 
> Bug fixed - No more crashing 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131028/594f123a/attachment.html>