[Kstars-devel] Review Request 113251: Added SkyObjDescription class to fetch description of skyobjects from Wikipedia for Whats Interesting tool

[Samikshan Bairagya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113251/#review42397
-----------------------------------------------------------


Could you submit another patch where the diff for the new files (skyobjdescription.*) which are added are made against /dev/null? Currently your patch assumes that the files already exists and hence it is not being possible to apply the patch.

- Samikshan Bairagya


On Oct. 14, 2013, 10 p.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113251/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 10 p.m.)
> 
> 
> Review request for KStars, Samikshan Bairagya and Rafal Kulaga.
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> SkyObjDescription class fetches data from Wikipedia Search API and parse it to get description of SkyObject if search was successful.  
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 51f7269 
>   kstars/tools/whatsinteresting/skyobjdescription.h e69de29 
>   kstars/tools/whatsinteresting/skyobjdescription.cpp e69de29 
>   kstars/tools/whatsinteresting/skyobjitem.h 3daa5c1 
>   kstars/tools/whatsinteresting/skyobjitem.cpp cb9ec41 
> 
> Diff: http://git.reviewboard.kde.org/r/113251/diff/
> 
> 
> Testing
> -------
> 
> Provides description in WI tool when connected to internet - No error
> Provides long name in description when not connected to internet - No error
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131026/f6123e37/attachment.html>