<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113251/">http://git.reviewboard.kde.org/r/113251/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you submit another patch where the diff for the new files (skyobjdescription.*) which are added are made against /dev/null? Currently your patch assumes that the files already exists and hence it is not being possible to apply the patch.</pre>
<br />
<p>- Samikshan Bairagya</p>
<br />
<p>On October 14th, 2013, 10 p.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Samikshan Bairagya and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2013, 10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">SkyObjDescription class fetches data from Wikipedia Search API and parse it to get description of SkyObject if search was successful. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Provides description in WI tool when connected to internet - No error
Provides long name in description when not connected to internet - No error</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(51f7269)</span></li>
<li>kstars/tools/whatsinteresting/skyobjdescription.h <span style="color: grey">(e69de29)</span></li>
<li>kstars/tools/whatsinteresting/skyobjdescription.cpp <span style="color: grey">(e69de29)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.h <span style="color: grey">(3daa5c1)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.cpp <span style="color: grey">(cb9ec41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113251/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>