[Kstars-devel] Review Request 113019: Update moon position code to Meeus 1998 and fixed bug in Time calculator->Almanac

[Vijay Dhameliya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113019/
-----------------------------------------------------------

Review request for KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.


Summary (updated)
-----------------

Update moon position code to Meeus 1998 and fixed bug in Time calculator->Almanac


Repository: kstars


Description (updated)
-------

As such there are no major changes made in Moon Position algorithm in Meeus 1998 from Meeus 1991 but few constants are modified which increases accuracy by few arc-seconds. 

Previously Tools->Calculator->Time Calculators->Almanac always produced phase unknown which is fixed by calling findPosition() and findPhase() before calling illum(). 


Diffs (updated)
-----

  kstars/skyobjects/ksmoon.cpp ac7e4ed 
  kstars/tools/modcalcdaylength.cpp b11cca2 

Diff: http://git.reviewboard.kde.org/r/113019/diff/


Testing (updated)
-------

Tools->Calculator->Time Calculators->Almanac produces correct phase.


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131009/210ff0ec/attachment.html>