[Kstars-devel] Review Request 110398: make kstars build on windows

[Patrick Spendrin]

> On May 12, 2013, 8:45 a.m., Alexander Wolf wrote:
> > You should use #ifdef's for Windows-specific code.

It is preferred to use a solution which works on all platforms before using ifdefs specific for one platform. ifdefs generally make it harder to have clean & portable code and should be used only when needed.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110398/#review32373
-----------------------------------------------------------


On May 11, 2013, 9:37 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110398/
> -----------------------------------------------------------
> 
> (Updated May 11, 2013, 9:37 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> I need some smaller fixes to build under windows. nevertheless I remember having submitted a similar fix already (which might have been reverted).
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/ksmoon.cpp 1372188 
> 
> Diff: http://git.reviewboard.kde.org/r/110398/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130512/191174cd/attachment.html>