[Kstars-devel] Review Request 110398: make kstars build on windows

Alexander Wolf alex.v.wolf at gmail.com
Sun May 12 08:45:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110398/#review32373
-----------------------------------------------------------


You should use #ifdef's for Windows-specific code.

- Alexander Wolf


On May 12, 2013, 4:37 a.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110398/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 4:37 a.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> I need some smaller fixes to build under windows. nevertheless I remember having submitted a similar fix already (which might have been reverted).
> 
> 
> Diffs
> -----
> 
>   kstars/skyobjects/ksmoon.cpp 1372188 
> 
> Diff: http://git.reviewboard.kde.org/r/110398/diff/
> 
> 
> Testing
> -------
> 
> Windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130512/6f1d7c58/attachment.html>


More information about the Kstars-devel mailing list