[Kstars-devel] Review Request 102119: Fix FindINDI CMake module

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102119/#review27118
-----------------------------------------------------------


Ping, what's the status of this? Should we commit the diff? Rework the diff? Discard the review request?

- Albert Astals Cid


On July 28, 2011, 4:36 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102119/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 4:36 p.m.)
> 
> 
> Review request for KStars.
> 
> 
> Description
> -------
> 
> The current FindINDI.cmake module feels more of a hack than a proper solution, it also does not detect libindi 0.8 on ubuntu.
> This patch is derived from upstream indi drivers which i feel have a better implementation of FindINDI.cmake
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindINDI.cmake 40d77a4 
> 
> Diff: http://git.reviewboard.kde.org/r/102119/diff/
> 
> 
> Testing
> -------
> 
> KStars now correctly detects libindi 0.8 on my Ubuntu machine
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130210/3eaf6e1a/attachment.html>