[Kstars-devel] Review Request 102091: Adding recent supernovae to KStars

[Samikshan Bairagya]

> On Feb. 6, 2013, 10:52 p.m., Albert Astals Cid wrote:
> > Has this been commited? It's has Ship it! (even though i see some questions outstanding) but still shows as open in reviewboard. If has not been commited should we discard it or are you planning on working on it?

Yes, this has been committed. 


- Samikshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102091/#review26794
-----------------------------------------------------------


On July 27, 2011, 5:51 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102091/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 5:51 a.m.)
> 
> 
> Review request for KStars, Akarsh Simha, Rafal Kulaga, and Victor Carbune.
> 
> 
> Description
> -------
> 
> This diff adds recently observed supernovae to KStars. Data is extracted from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a python script.
> Data is stored in a CSV format. The supernovae are drawn on the skymap as small orange plus signs. Also Supernovae maybe found out by name from the Find 
> Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() method.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 0c335b6 
>   kstars/colorscheme.cpp 9d669a1 
>   kstars/data/CMakeLists.txt 64493f0 
>   kstars/data/chart.colors 5515c1b 
>   kstars/data/classic.colors 31e6706 
>   kstars/data/moonless-night.colors c1d3b06 
>   kstars/data/night.colors a31f69e 
>   kstars/data/scripts/supernova_updates_parser.py 9833458 
>   kstars/kstars.h 6516f9e 
>   kstars/kstars.kcfg 6d088d7 
>   kstars/kstarsactions.cpp e917cac 
>   kstars/kstarsdata.cpp 2303c5f 
>   kstars/kstarsinit.cpp 7f4471e 
>   kstars/skycomponents/skymapcomposite.h adf496d 
>   kstars/skycomponents/skymapcomposite.cpp 82fef8a 
>   kstars/skycomponents/supernovaecomponent.h PRE-CREATION 
>   kstars/skycomponents/supernovaecomponent.cpp PRE-CREATION 
>   kstars/skyglpainter.h 2aa8d87 
>   kstars/skyglpainter.cpp 655d2c7 
>   kstars/skyobjects/skyobject.h 3a6122f 
>   kstars/skyobjects/supernova.h PRE-CREATION 
>   kstars/skyobjects/supernova.cpp PRE-CREATION 
>   kstars/skypainter.h 1340568 
>   kstars/skyqpainter.h df7cc9b 
>   kstars/skyqpainter.cpp 87719b2 
> 
> Diff: http://git.reviewboard.kde.org/r/102091/diff/
> 
> 
> Testing
> -------
> 
> Testing has been done with all colour schemes and in QPainter backend.
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130207/eaa992a5/attachment.html>