<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102091/">http://git.reviewboard.kde.org/r/102091/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2013, 10:52 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been commited? It's has Ship it! (even though i see some questions outstanding) but still shows as open in reviewboard. If has not been commited should we discard it or are you planning on working on it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, this has been committed. </pre>
<br />
<p>- Samikshan</p>
<br />
<p>On July 27th, 2011, 5:51 a.m. UTC, Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Akarsh Simha, Rafal Kulaga, and Victor Carbune.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated July 27, 2011, 5:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff adds recently observed supernovae to KStars. Data is extracted from http://www.cbat.eps.harvard.edu/lists/RecentSupernovae.html using a python script.
Data is stored in a CSV format. The supernovae are drawn on the skymap as small orange plus signs. Also Supernovae maybe found out by name from the Find
Object dialog.box. I have yet to write the SkyGLPainter::drawSupernova() method.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing has been done with all colour schemes and in QPainter backend.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(0c335b6)</span></li>
<li>kstars/colorscheme.cpp <span style="color: grey">(9d669a1)</span></li>
<li>kstars/data/CMakeLists.txt <span style="color: grey">(64493f0)</span></li>
<li>kstars/data/chart.colors <span style="color: grey">(5515c1b)</span></li>
<li>kstars/data/classic.colors <span style="color: grey">(31e6706)</span></li>
<li>kstars/data/moonless-night.colors <span style="color: grey">(c1d3b06)</span></li>
<li>kstars/data/night.colors <span style="color: grey">(a31f69e)</span></li>
<li>kstars/data/scripts/supernova_updates_parser.py <span style="color: grey">(9833458)</span></li>
<li>kstars/kstars.h <span style="color: grey">(6516f9e)</span></li>
<li>kstars/kstars.kcfg <span style="color: grey">(6d088d7)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(e917cac)</span></li>
<li>kstars/kstarsdata.cpp <span style="color: grey">(2303c5f)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(7f4471e)</span></li>
<li>kstars/skycomponents/skymapcomposite.h <span style="color: grey">(adf496d)</span></li>
<li>kstars/skycomponents/skymapcomposite.cpp <span style="color: grey">(82fef8a)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skyglpainter.h <span style="color: grey">(2aa8d87)</span></li>
<li>kstars/skyglpainter.cpp <span style="color: grey">(655d2c7)</span></li>
<li>kstars/skyobjects/skyobject.h <span style="color: grey">(3a6122f)</span></li>
<li>kstars/skyobjects/supernova.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skyobjects/supernova.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/skypainter.h <span style="color: grey">(1340568)</span></li>
<li>kstars/skyqpainter.h <span style="color: grey">(df7cc9b)</span></li>
<li>kstars/skyqpainter.cpp <span style="color: grey">(87719b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102091/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>