[Kstars-devel] Review Request 114375: Moving addlink() from skymap to detaildialogue class and fixing edit link under links tab in the same

[Vijay Dhameliya]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114375/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 3:05 a.m.)


Status
------

This change has been marked as submitted.


Review request for KStars, Samikshan Bairagya and Rafal Kulaga.


Bugs: 328607
    http://bugs.kde.org/show_bug.cgi?id=328607


Repository: kstars


Description
-------

Actually addlink() was placed in skymap which restricted its use to last clicked skyobject and while accessing it from dialogue box of any other skyobject will also add link to last clicked object. 

And edit link dialogue used to saw object description in both fields, i.e. description field and link field   

Detail of current buggy scenario is well explained in attached bug.


Diffs
-----

  kstars/dialogs/detaildialog.h b08daa1 
  kstars/dialogs/detaildialog.cpp ed9848a 
  kstars/skymap.h dd67cd8 
  kstars/skymap.cpp eb532d1 

Diff: https://git.reviewboard.kde.org/r/114375/diff/


Testing
-------

Tested


Thanks,

Vijay Dhameliya

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20131224/bb194d8f/attachment.html>