[Kstars-devel] Review Request 102332: Fix bug that causes KStars to crash (segmentation fault) in Options window, before TLEs update.

Albert Astals Cid aacid at kde.org
Fri Apr 5 15:50:32 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102332/
-----------------------------------------------------------

(Updated April 5, 2013, 3:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KStars, Akarsh Simha, Rafal Kulaga, and Victor Carbune.


Description
-------

Patch that fixes KStars crashing when Options window was closed, before TLEs are update. Crash was in OpsSatellites::slotItemChanged(), because before TLEs are updated, parent of item which was accessed was 0x0. This patch also fixes view's header (it was '1' because model was cleared after header was set) and makes items read-only.


Diffs
-----

  kstars/options/opssatellites.cpp 7d4fc88 

Diff: http://git.reviewboard.kde.org/r/102332/diff/


Testing
-------

Tested, fixes the problem.


Thanks,

Łukasz Jaśkiewicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20130405/07759c99/attachment.html>


More information about the Kstars-devel mailing list