[Kstars-devel] Review Request: Review request for merging gsoc2012-samxan branch to master.

[Samikshan Bairagya]

> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/data/PlanetFacts.dat, line 2
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84113#file84113line2>
> >
> >     I guess we should include that information also in the user interface to be 100% fair.

True.


> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/kstars.cpp, line 335
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84115#file84115line335>
> >
> >     Inconsistent code formatting.

I decided to go with the convention that was being used in that particular file i.e. kstars/kstars.cpp


> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/obsconditions.h, line 38
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84123#file84123line38>
> >
> >     Why Telescope = 0? Is that fact used somewhere else?

Telescope = 0 is not required. Thanks.


> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/skyobjitem.h, line 22
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84133#file84133line22>
> >
> >     Are you using QObject somewhere here?

Removed that.


> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/skyobjitem.cpp, line 27
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84134#file84134line27>
> >
> >     I don't like this way of doing stuff. Why do we introduce a few enum types that essentialy represent the same stuff?

Using enums like Nebula and Cluster which group together different type of nebulae and clusters increases convenience in this case. Dealing with the three types of nebulae and clusters is not required.


> On Sept. 23, 2012, 8:13 p.m., Rafal Kulaga wrote:
> > kstars/tools/whatsinteresting/obsconditions.cpp, line 44
> > <http://git.reviewboard.kde.org/r/106371/diff/1/?file=84124#file84124line44>
> >
> >     Somewhat more ugly. Why don't use QMap<int, double> to implement the lookup table?

I used a private static const QMap<int, double> for this. You might want to check that out. 


- Samikshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106371/#review19365
-----------------------------------------------------------


On Sept. 7, 2012, 5:14 p.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106371/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 5:14 p.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> This is the request to review the mergeabilty of the gsoc2012-samxan branch which introduces the "What's Interesting..." feature in KStars.
> 
> This feature suggests sky-objects to beginner astronomers depending on such parameters like light pollution and equipment specifications,
> in a QML user interface.
> 
> Added new "whatsinteresting" directory under kstars/tools/ containing all the source code related to this new feature.
> kstars/tools/whatsinteresing/qml comtains all files for the QML UI.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 2c99bb1 
>   kstars/Messages.sh 7d56711 
>   kstars/data/CMakeLists.txt 0dc591b 
>   kstars/data/Interesting.dat PRE-CREATION 
>   kstars/data/PlanetFacts.dat PRE-CREATION 
>   kstars/kstars.h ad4b52f 
>   kstars/kstars.cpp 1512b67 
>   kstars/kstarsactions.cpp 4f03e30 
>   kstars/kstarsinit.cpp 3baec6c 
>   kstars/kstarsui-indi.rc 1b44e5f 
>   kstars/kstarsui-win.rc eb23e82 
>   kstars/kstarsui.rc ee56cf3 
>   kstars/tools/whatsinteresting/modelmanager.h PRE-CREATION 
>   kstars/tools/whatsinteresting/modelmanager.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.h PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/ScrollBar.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/dialog_close.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/leftArrow.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/next.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/previous.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/settingsIcon.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/wiview.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.ui PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106371/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20121031/448b48d2/attachment.html>