<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106371/">http://git.reviewboard.kde.org/r/106371/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84113#file84113line2" style="color: black; font-weight: bold; text-decoration: underline;">kstars/data/PlanetFacts.dat</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "># The following data for the planets in the solar system has been obtained from http://wikipedia.org/. The text is available under the Creative Commons Attribution-ShareAlike License. #</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess we should include that information also in the user interface to be 100% fair.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84115#file84115line335" style="color: black; font-weight: bold; text-decoration: underline;">kstars/kstars.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KStars::showWI(ObsConditions *obs)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">335</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="o">!</span> <span class="n">wi</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Inconsistent code formatting.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I decided to go with the convention that was being used in that particular file i.e. kstars/kstars.cpp</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84123#file84123line38" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/obsconditions.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">enum</span> <span class="n">Equipment</span> <span class="p">{</span> <span class="n">Telescope</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span> <span class="n">Binoculars</span><span class="p">,</span> <span class="n">Both</span><span class="p">,</span> <span class="n">None</span> <span class="p">};</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why Telescope = 0? Is that fact used somewhere else?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Telescope = 0 is not required. Thanks.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84124#file84124line44" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/obsconditions.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ObsConditions::setLimMagnitude()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">case</span> <span class="mi">1</span><span class="o">:</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Somewhat more ugly. Why don't use QMap<int, double> to implement the lookup table?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I used a private static const QMap<int, double> for this. You might want to check that out. </pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84133#file84133line22" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/skyobjitem.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QObject></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Are you using QObject somewhere here?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed that.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 23rd, 2012, 8:13 p.m., <b>Rafal Kulaga</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106371/diff/1/?file=84134#file84134line27" style="color: black; font-weight: bold; text-decoration: underline;">kstars/tools/whatsinteresting/skyobjitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SkyObjItem::SkyObjItem(SkyObject *so) : m_Name(so->name()), m_LongName(so->longname()),m_TypeName(so->typeName()), m_So(so)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">switch</span> <span class="p">(</span><span class="n">so</span><span class="o">-></span><span class="n">type</span><span class="p">())</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like this way of doing stuff. Why do we introduce a few enum types that essentialy represent the same stuff?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using enums like Nebula and Cluster which group together different type of nebulae and clusters increases convenience in this case. Dealing with the three types of nebulae and clusters is not required.</pre>
<br />
<p>- Samikshan</p>
<br />
<p>On September 7th, 2012, 5:14 p.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2012, 5:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the request to review the mergeabilty of the gsoc2012-samxan branch which introduces the "What's Interesting..." feature in KStars.
This feature suggests sky-objects to beginner astronomers depending on such parameters like light pollution and equipment specifications,
in a QML user interface.
Added new "whatsinteresting" directory under kstars/tools/ containing all the source code related to this new feature.
kstars/tools/whatsinteresing/qml comtains all files for the QML UI.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/CMakeLists.txt <span style="color: grey">(2c99bb1)</span></li>
<li>kstars/Messages.sh <span style="color: grey">(7d56711)</span></li>
<li>kstars/data/CMakeLists.txt <span style="color: grey">(0dc591b)</span></li>
<li>kstars/data/Interesting.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/data/PlanetFacts.dat <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/kstars.h <span style="color: grey">(ad4b52f)</span></li>
<li>kstars/kstars.cpp <span style="color: grey">(1512b67)</span></li>
<li>kstars/kstarsactions.cpp <span style="color: grey">(4f03e30)</span></li>
<li>kstars/kstarsinit.cpp <span style="color: grey">(3baec6c)</span></li>
<li>kstars/kstarsui-indi.rc <span style="color: grey">(1b44e5f)</span></li>
<li>kstars/kstarsui-win.rc <span style="color: grey">(eb23e82)</span></li>
<li>kstars/kstarsui.rc <span style="color: grey">(ee56cf3)</span></li>
<li>kstars/tools/whatsinteresting/modelmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/modelmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/obsconditions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/obsconditions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/ScrollBar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/dialog_close.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/leftArrow.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/next.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/previous.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/settingsIcon.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/qml/wiview.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/skyobjlistmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiusersettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiview.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/tools/whatsinteresting/wiview.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>