[Kstars-devel] Review Request: My entire GSoC work till now. What's Interesting works for planets, bright stars and constellations now.

[Samikshan Bairagya]

> On July 13, 2012, 3:33 p.m., Akarsh Simha wrote:
> > kstars/indi/indielement.h, line 47
> > <http://git.reviewboard.kde.org/r/105481/diff/1/?file=71811#file71811line47>
> >
> >     Eh?

I do not know why this was included in the diff. I have not made this change. These two lines was added by Kevin Kofler on master branch through revision 93be2ba.


> On July 13, 2012, 3:33 p.m., Akarsh Simha wrote:
> > kstars/data/PlanetFacts.dat, line 1
> > <http://git.reviewboard.kde.org/r/105481/diff/1/?file=71809#file71809line1>
> >
> >     Where did you get these facts from? If you wrote them yourself, perfect. If you got them from somewhere, we should check that the source is compatible with GPL, and cite it with appropriate credit / copyright.

I got these facts from wikipedia.org.


- Samikshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105481/#review15549
-----------------------------------------------------------


On July 31, 2012, 10:21 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105481/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 10:21 a.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> QML user interface for testing purpose ready. This shows planets, bright stars, constellations and deep-sky object. Description not yet available for bright stars and constellations. The details-view is not ready for DSOs. Also the list of DSOs displayed is not the filtered or interesting list.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 8c228de 
>   kstars/data/CMakeLists.txt 0dc591b 
>   kstars/data/Interesting.dat PRE-CREATION 
>   kstars/data/PlanetFacts.dat PRE-CREATION 
>   kstars/kstars.h c9e4261 
>   kstars/kstars.cpp 02661bb 
>   kstars/kstarsactions.cpp d2260ef 
>   kstars/kstarsinit.cpp 5bcefa2 
>   kstars/kstarsui-indi.rc d5a038a 
>   kstars/kstarsui-win.rc eb23e82 
>   kstars/kstarsui.rc ee56cf3 
>   kstars/tools/whatsinteresting/modelmanager.h PRE-CREATION 
>   kstars/tools/whatsinteresting/modelmanager.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.h PRE-CREATION 
>   kstars/tools/whatsinteresting/obsconditions.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/Button.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/CMakeLists.txt PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/cluster.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/constellation.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/dso.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/galaxy.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/nebula.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/planets.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/stars.jpg PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/stripes.png PRE-CREATION 
>   kstars/tools/whatsinteresting/qml/wiview.qml PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjitem.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.h PRE-CREATION 
>   kstars/tools/whatsinteresting/skyobjlistmodel.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.cpp PRE-CREATION 
>   kstars/tools/whatsinteresting/wiusersettings.ui PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.h PRE-CREATION 
>   kstars/tools/whatsinteresting/wiview.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105481/diff/
> 
> 
> Testing
> -------
> 
> Testing done for planets, constellations, bright stars. Details-view not yet ready for DSOs.
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120731/34de9761/attachment-0001.html>