[Kstars-devel] Review Request: My entire GSoC work till now. What's Interesting works for planets, bright stars and constellations now.

[Akarsh Simha]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105481/#review15549
-----------------------------------------------------------


Here's few comments. More will come later.


kstars/data/PlanetFacts.dat
<http://git.reviewboard.kde.org/r/105481/#comment12156>

    Where did you get these facts from? If you wrote them yourself, perfect. If you got them from somewhere, we should check that the source is compatible with GPL, and cite it with appropriate credit / copyright.



kstars/indi/indielement.h
<http://git.reviewboard.kde.org/r/105481/#comment12157>

    Eh?



kstars/kstarsactions.cpp
<http://git.reviewboard.kde.org/r/105481/#comment12152>

    How is the deletion of wi to free up space later managed? Maybe you should do something similar to what is done for WUTDialog just above.



kstars/kstarsui-indi.rc
<http://git.reviewboard.kde.org/r/105481/#comment12154>

    Indent



kstars/kstarsui-win.rc
<http://git.reviewboard.kde.org/r/105481/#comment12155>

    Indent



kstars/kstarsui.rc
<http://git.reviewboard.kde.org/r/105481/#comment12153>

    Indent



kstars/tools/WhatsInteresting/WIView.cpp
<http://git.reviewboard.kde.org/r/105481/#comment12158>

    Eh???


- Akarsh Simha


On July 8, 2012, 5:55 p.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105481/
> -----------------------------------------------------------
> 
> (Updated July 8, 2012, 5:55 p.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> QML user interface for testing purpose ready. This shows planets, bright stars, constellations and deep-sky object. Description not yet available for bright stars and constellations. The details-view is not ready for DSOs. Also the list of DSOs displayed is not the filtered or interesting list.
> 
> 
> Diffs
> -----
> 
>   kstars/CMakeLists.txt 1113333 
>   kstars/data/CMakeLists.txt 0dc591b 
>   kstars/data/Interesting.dat PRE-CREATION 
>   kstars/data/PlanetFacts.dat PRE-CREATION 
>   kstars/data/initWIList.dat PRE-CREATION 
>   kstars/indi/indielement.h 93be2ba 
>   kstars/kstars.h 959f042 
>   kstars/kstarsactions.cpp e2f8fc5 
>   kstars/kstarsinit.cpp bbc70fe 
>   kstars/kstarsui-indi.rc d2bbdb0 
>   kstars/kstarsui-win.rc 20a2fa0 
>   kstars/kstarsui.rc 1f28415 
>   kstars/tools/WhatsInteresting/Base.qml PRE-CREATION 
>   kstars/tools/WhatsInteresting/CMakeLists.txt PRE-CREATION 
>   kstars/tools/WhatsInteresting/WIView.h PRE-CREATION 
>   kstars/tools/WhatsInteresting/WIView.cpp PRE-CREATION 
>   kstars/tools/WhatsInteresting/modelmanager.h PRE-CREATION 
>   kstars/tools/WhatsInteresting/modelmanager.cpp PRE-CREATION 
>   kstars/tools/WhatsInteresting/skyobjitem.h PRE-CREATION 
>   kstars/tools/WhatsInteresting/skyobjitem.cpp PRE-CREATION 
>   kstars/tools/WhatsInteresting/skyobjlistmodel.h PRE-CREATION 
>   kstars/tools/WhatsInteresting/skyobjlistmodel.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105481/diff/
> 
> 
> Testing
> -------
> 
> Testing done for planets, constellations, bright stars. Details-view not yet ready for DSOs.
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20120713/bc5ff314/attachment.html>