[Kstars-devel] Re: Review Request: Add SVG format support for sky image export function.

[Victor Carbune]

Hi Rafal,

Feel free to work on patches or minor changes different than your main GSoC
project directly with the master branch.
Most likely, at some point, you will have no other way to do that anyway
(since the GSoC branch will probably have lots of changes specifically for
your project).

Victor

On Mon, May 2, 2011 at 2:54 PM, Rafal Kulaga <rl.kulaga at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101268/
>
> On May 1st, 2011, 9:33 p.m., *Aleksey Khudyakov* wrote:
>
> Looks fine. Although return from middle of function do not improve readability.
> Probably it's better to structure code like that:
>
> if( save_to_SVG ) {
>    // Save to SVG
> } else {
>    // Save to raster format
>
> }
>
>
> Please add following line to commit message? I'll close bug in meantime
>
> CCBUG: 109042
>
>  I have pushed the changes to gsoc2011 branch, which was created by Victor for my GSoC project. Should I also use this branch for all my patches (including bug-fixes) or commit changes directly to the master branch after positive review?
>
> Also, thanks for your comments on my code!
>
>
> - Rafal
>
> On May 2nd, 2011, 11:48 a.m., Rafal Kulaga wrote:
>   Review request for KStars.
> By Rafal Kulaga.
>
> *Updated May 2, 2011, 11:48 a.m.*
> Description
>
> Class QSvgGenerator is used as a QPaintDevice for SkyMapDrawAbstract::exportSkyImage() method.
>
> Overlays, names etc. are saved as vector graphics; sky images are saved as raster graphics (<image> element).
>
>   Testing
>
> Done basic testing, no problems detected.
>
>   Diffs
>
>    - kstars/kstarsactions.cpp (d0f4094)
>    - kstars/kstarsdcop.cpp (a70d732)
>
> View Diff <http://git.reviewboard.kde.org/r/101268/diff/>
>
> _______________________________________________
> Kstars-devel mailing list
> Kstars-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110502/e7b74db8/attachment.htm