Hi Rafal,<div><br></div><div>Feel free to work on patches or minor changes different than your main GSoC project directly with the master branch.</div><div>Most likely, at some point, you will have no other way to do that anyway (since the GSoC branch will probably have lots of changes specifically for your project).</div>
<div><br></div><div>Victor <br><br><div class="gmail_quote">On Mon, May 2, 2011 at 2:54 PM, Rafal Kulaga <span dir="ltr"><<a href="mailto:rl.kulaga@gmail.com">rl.kulaga@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101268/" target="_blank">http://git.reviewboard.kde.org/r/101268/</a>
</td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><div class="im">
<p style="margin-top:0">On May 1st, 2011, 9:33 p.m., <b>Aleksey Khudyakov</b> wrote:</p>
</div><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Looks fine. Although return from middle of function do not improve readability.
Probably it's better to structure code like that:
if( save_to_SVG ) {
// Save to SVG
} else {
// Save to raster format
}
Please add following line to commit message? I'll close bug in meantime
CCBUG: 109042 </pre>
</blockquote>
</blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I have pushed the changes to gsoc2011 branch, which was created by Victor for my GSoC project. Should I also use this branch for all my patches (including bug-fixes) or commit changes directly to the master branch after positive review?
Also, thanks for your comments on my code!</pre>
<br>
<p>- Rafal</p><div class="im">
<br>
<p>On May 2nd, 2011, 11:48 a.m., Rafal Kulaga wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div class="im">
<div>Review request for KStars.</div>
<div>By Rafal Kulaga.</div>
</div><p style="color:grey"><i>Updated May 2, 2011, 11:48 a.m.</i></p><div class="im">
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Class QSvgGenerator is used as a QPaintDevice for SkyMapDrawAbstract::exportSkyImage() method.
Overlays, names etc. are saved as vector graphics; sky images are saved as raster graphics (<image> element).</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Done basic testing, no problems detected.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kstars/kstarsactions.cpp <span style="color:grey">(d0f4094)</span></li>
<li>kstars/kstarsdcop.cpp <span style="color:grey">(a70d732)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101268/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Kstars-devel mailing list<br>
<a href="mailto:Kstars-devel@kde.org">Kstars-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kstars-devel" target="_blank">https://mail.kde.org/mailman/listinfo/kstars-devel</a><br>
<br></blockquote></div><br></div>