[Kstars-devel] Review Request: Many changes to flags feature making them work well as annotations for printouts

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101939/
-----------------------------------------------------------

Review request for KStars, Victor Carbune and Akarsh Simha.


Summary
-------

This diff adds several additional features to current implementation of flags, making it more useful (and user friendly), especially when used to mark sky points (or sky objects) for printing. 

Features added include:
 * access to Add/Edit/Delete flag commands through (nice) SkyMap's popup menu.
 * enabled editing for existing flags.

As you can see, FlagManager class was refactored quite deeply and is now flags.dat-agnostic. All changes are saved to FlagComponent, which in this case acts as a model for all flag-related code. 

Small TODOs remain: allowing flags without images (label-only) and better handling of zoom level changes (hide labels at small zoom levels).

Apart from that, when should flags be saved to flags.dat file? Currently it's done for every flag insertion/deletion/edition which is suboptimal approach. Should we save current flags when KStars is quitted?

Ah, and sorry for stray whitespaces, they're already removed.


Diffs
-----

  kstars/kspopupmenu.h ba9c3ab 
  kstars/kspopupmenu.cpp f04d822 
  kstars/kstars.h 6516f9e 
  kstars/kstars.cpp d067e11 
  kstars/skycomponents/flagcomponent.h 44560b7 
  kstars/skycomponents/flagcomponent.cpp 82063ba 
  kstars/skymap.h e7a7f56 
  kstars/skymap.cpp afbf19b 
  kstars/tools/flagmanager.h 68351b6 
  kstars/tools/flagmanager.cpp 7cb99a8 
  kstars/tools/flagmanager.ui 86fe77c 

Diff: http://git.reviewboard.kde.org/r/101939/diff


Testing
-------

Done quite extensive testing, no problems detected.


Thanks,

Rafal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110713/d166e730/attachment-0001.htm