<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101939/">http://git.reviewboard.kde.org/r/101939/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Victor Carbune and Akarsh Simha.</div>
<div>By Rafal Kulaga.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This diff adds several additional features to current implementation of flags, making it more useful (and user friendly), especially when used to mark sky points (or sky objects) for printing.
Features added include:
* access to Add/Edit/Delete flag commands through (nice) SkyMap's popup menu.
* enabled editing for existing flags.
As you can see, FlagManager class was refactored quite deeply and is now flags.dat-agnostic. All changes are saved to FlagComponent, which in this case acts as a model for all flag-related code.
Small TODOs remain: allowing flags without images (label-only) and better handling of zoom level changes (hide labels at small zoom levels).
Apart from that, when should flags be saved to flags.dat file? Currently it's done for every flag insertion/deletion/edition which is suboptimal approach. Should we save current flags when KStars is quitted?
Ah, and sorry for stray whitespaces, they're already removed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done quite extensive testing, no problems detected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/kspopupmenu.h <span style="color: grey">(ba9c3ab)</span></li>
<li>kstars/kspopupmenu.cpp <span style="color: grey">(f04d822)</span></li>
<li>kstars/kstars.h <span style="color: grey">(6516f9e)</span></li>
<li>kstars/kstars.cpp <span style="color: grey">(d067e11)</span></li>
<li>kstars/skycomponents/flagcomponent.h <span style="color: grey">(44560b7)</span></li>
<li>kstars/skycomponents/flagcomponent.cpp <span style="color: grey">(82063ba)</span></li>
<li>kstars/skymap.h <span style="color: grey">(e7a7f56)</span></li>
<li>kstars/skymap.cpp <span style="color: grey">(afbf19b)</span></li>
<li>kstars/tools/flagmanager.h <span style="color: grey">(68351b6)</span></li>
<li>kstars/tools/flagmanager.cpp <span style="color: grey">(7cb99a8)</span></li>
<li>kstars/tools/flagmanager.ui <span style="color: grey">(86fe77c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101939/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>