[Kstars-devel] Re: Review Request: Legend feature (currently used only for exported images)

[Victor Carbune]

On Tue, Jul 12, 2011 at 8:41 AM, Victor Carbune <victor.carbune at gmail.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101912/
>
> Ship it!
>
If you addressed Akarsh's comments as well, when you're confident, merge it
in master.

>  Looks good, Rafal.
>
>
>    kstars/legend.cpp<http://git.reviewboard.kde.org/r/101912/diff/1/?file=26665#file26665line359> (Diff
> revision 1)
>
> void Legend::paintSymbol(QPointF pos, int type, float e, float angle, QString label)
>
>    359
>
>     //m_Painter->drawRect(bRect);
>
>   remove commented code
>
>
>    kstars/legend.cpp<http://git.reviewboard.kde.org/r/101912/diff/1/?file=26665#file26665line464> (Diff
> revision 1)
>
> void Legend::paintSymbol(QPointF pos, int type, float e, float angle, QString label)
>
>    464
>
>             //m_Painter->drawRect(bRect);
>
>   remove commented code
>
>
> - Victor
>
> On July 10th, 2011, 10:38 p.m., Rafal Kulaga wrote:
>   Review request for KStars, Victor Carbune and Akarsh Simha.
> By Rafal Kulaga.
>
> *Updated July 10, 2011, 10:38 p.m.*
> Description
>
> Attached diff adds the option to include legends in exported sky images. Both vertical and horizontal orientations are supported; there are two types of legend: full-blown (symbol descriptions, star magnitudes and scale) and scale-only. Some changes will inevitably be made to this code in a few days - please note that there are some hard-coded values in legend.cpp which will be gone after integration with the functionality I am developing now (FOV representation exporting).
>
> Any comments are welcome, be they look&feel or code-related.
>
>   Testing
>
> Done some testing, everything worked (and looked) fine for me.
>
>   Diffs
>
>    - kstars/CMakeLists.txt (0c335b6)
>    - kstars/dialogs/exportimagedialog.h (PRE-CREATION)
>    - kstars/dialogs/exportimagedialog.cpp (PRE-CREATION)
>    - kstars/dialogs/exportimagedialog.ui (PRE-CREATION)
>    - kstars/kstarsactions.cpp (e917cac)
>    - kstars/kstarsdcop.cpp (42dcb0f)
>    - kstars/legend.h (PRE-CREATION)
>    - kstars/legend.cpp (PRE-CREATION)
>    - kstars/skymap.h (e7a7f56)
>    - kstars/skymapdrawabstract.h (c94a745)
>    - kstars/skymapdrawabstract.cpp (cf44fc5)
>    - kstars/skypainter.h (1340568)
>    - kstars/skyqpainter.h (df7cc9b)
>    - kstars/skyqpainter.cpp (87719b2)
>
> View Diff <http://git.reviewboard.kde.org/r/101912/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20110712/b6755d6b/attachment.htm