<div class="gmail_quote">On Tue, Jul 12, 2011 at 8:41 AM, Victor Carbune <span dir="ltr"><<a href="mailto:victor.carbune@gmail.com">victor.carbune@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101912/" target="_blank">http://git.reviewboard.kde.org/r/101912/</a>
</td>
</tr>
</tbody></table>
<br>
</div><p>Ship it!</p></div></div></blockquote><div>If you addressed Akarsh's comments as well, when you're confident, merge it in master. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div style="font-family:Verdana, Arial, Helvetica, Sans-Serif">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Looks good, Rafal.</pre>
<br>
<div>
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/101912/diff/1/?file=26665#file26665line359" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">kstars/legend.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">void Legend::paintSymbol(QPointF pos, int type, float e, float angle, QString label)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">359</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>//m_Painter->drawRect(bRect);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">remove commented code</pre>
</div>
<br>
<div>
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/101912/diff/1/?file=26665#file26665line464" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">kstars/legend.cpp</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">void Legend::paintSymbol(QPointF pos, int type, float e, float angle, QString label)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"></pre></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">464</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>//m_Painter->drawRect(bRect);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left:2em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">remove commented code</pre>
</div>
<br>
<p>- Victor</p><div class="im">
<br>
<p>On July 10th, 2011, 10:38 p.m., Rafal Kulaga wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td><div class="im">
<div>Review request for KStars, Victor Carbune and Akarsh Simha.</div>
<div>By Rafal Kulaga.</div>
</div><p style="color:grey"><i>Updated July 10, 2011, 10:38 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div class="im">
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Attached diff adds the option to include legends in exported sky images. Both vertical and horizontal orientations are supported; there are two types of legend: full-blown (symbol descriptions, star magnitudes and scale) and scale-only. Some changes will inevitably be made to this code in a few days - please note that there are some hard-coded values in legend.cpp which will be gone after integration with the functionality I am developing now (FOV representation exporting).
Any comments are welcome, be they look&feel or code-related.
</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Done some testing, everything worked (and looked) fine for me.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kstars/CMakeLists.txt <span style="color:grey">(0c335b6)</span></li>
<li>kstars/dialogs/exportimagedialog.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>kstars/dialogs/exportimagedialog.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>kstars/dialogs/exportimagedialog.ui <span style="color:grey">(PRE-CREATION)</span></li>
<li>kstars/kstarsactions.cpp <span style="color:grey">(e917cac)</span></li>
<li>kstars/kstarsdcop.cpp <span style="color:grey">(42dcb0f)</span></li>
<li>kstars/legend.h <span style="color:grey">(PRE-CREATION)</span></li>
<li>kstars/legend.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>kstars/skymap.h <span style="color:grey">(e7a7f56)</span></li>
<li>kstars/skymapdrawabstract.h <span style="color:grey">(c94a745)</span></li>
<li>kstars/skymapdrawabstract.cpp <span style="color:grey">(cf44fc5)</span></li>
<li>kstars/skypainter.h <span style="color:grey">(1340568)</span></li>
<li>kstars/skyqpainter.h <span style="color:grey">(df7cc9b)</span></li>
<li>kstars/skyqpainter.cpp <span style="color:grey">(87719b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101912/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>