[Kstars-devel] Review Request: Dialog for Supernova options. Implemented the option for users to see supernovae on the skymap.

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103530/#review9373
-----------------------------------------------------------


Hi Samikshan and sorry for late review.

I really like this options page, but I've got a few ideas that you might want to use. Here they are:

1) Should checkboxes be tristate? I don't see much use for this here.

2) The entire form looks good, but I'd decrease spacing between "Enable/Disable Supernova alerts" checkbox and "Update..." button. I'd do the same with spacing between this button and magnitude limits.

3) "Enable/Disable Supernova alerts" - shouldn't it be named "Enable Supernova alerts"? After all it's the checkbox that represents this "Enable/Disable" part ;-)

4) It would be nice to have consistent capitalization of "Supernovae" in all labels of this form.

As you can see, these are all cosmetic changes. I haven't noticed other problems :-)



- Rafal Kulaga


On Dec. 25, 2011, 11:34 a.m., Samikshan Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103530/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2011, 11:34 a.m.)
> 
> 
> Review request for KStars, Rafal Kulaga and Akarsh Simha.
> 
> 
> Description
> -------
> 
> Worked on the problems of my earlier review request and fixed them. There's no icon for Supernova now. Users can choose to either have or not have supernovae on their skymap. Notifications for new supernovae is not yet implemented.
> 
> 
> Diffs
> -----
> 
>   kstars/kstarsactions.cpp 15d2552 
>   kstars/kstarsdcop.cpp c045e47 
>   kstars/options/opssupernovae.h PRE-CREATION 
>   kstars/options/opssupernovae.cpp PRE-CREATION 
>   kstars/options/opssupernovae.ui PRE-CREATION 
>   kstars/CMakeLists.txt 6f7ed20 
>   kstars/kstars.h aa76633 
>   kstars/kstars.kcfg 986f322 
>   kstars/skycomponents/supernovaecomponent.h ab824c6 
>   kstars/skycomponents/supernovaecomponent.cpp 5c3c8bb 
> 
> Diff: http://git.reviewboard.kde.org/r/103530/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dialog window for Supernova
>   http://git.reviewboard.kde.org/r/103530/s/381/
> 
> 
> Thanks,
> 
> Samikshan Bairagya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20111231/86e5773b/attachment.html>